Refactor user and instance manager (#837)

* Refactor UserManager to use Datastore

* Rename lib.User to UserDetails also adds to/fromUserDetails

* Fix existing tests

* Add user class tests

* Add tests for finaliseUsers

* Move HostDetails to own file with tests

* Move InstanceDetails to its own file with tests

* Rename HostInfo and add tests

* Rename InstanceInfo and add tests

- Also changes the names of the host properties related to instances
- Also removes the need to specify the location of InstanceInfo

* Make json round trip test validate schema

* Add InstanceManager

* Fix lint errors

* Extra tests

* Add final test coverage

* Add one last test to InstanceManager

* Response to comments

* Use generator rather than return anonumous generator

Co-authored-by: Hornwitser <github@hornwitser.no>

* Fix lint issue with generator

---------

Co-authored-by: Hornwitser <github@hornwitser.no>

test/messages/controller.test.js

@@ -2,7 +2,7 @@
 const assert = require("assert").strict;
 const lib = require("@clusterio/lib");
 
-const { Controller, ControlConnection, ControllerUser } = require("@clusterio/controller");
+const { Controller, ControlConnection } = require("@clusterio/controller");
 
 describe("messages/controller", function() {
 	/** @type {Controller} */
@@ -17,7 +17,7 @@ describe("messages/controller", function() {
 			lib.Address.fromShorthand({ controlId: 1 }),
 		);
 		controller = new Controller(lib.logger, [], controllerConfig);
-		const user = new ControllerUser(controller.userManager, undefined, "test");
+		const user = controller.users.getOrCreateUser("test");
 		controlConnection = new ControlConnection({ version: "2.0.0" }, connection, controller, user, 1);
 	});