Refactor user and instance manager (#837)

* Refactor UserManager to use Datastore

* Rename lib.User to UserDetails also adds to/fromUserDetails

* Fix existing tests

* Add user class tests

* Add tests for finaliseUsers

* Move HostDetails to own file with tests

* Move InstanceDetails to its own file with tests

* Rename HostInfo and add tests

* Rename InstanceInfo and add tests

- Also changes the names of the host properties related to instances
- Also removes the need to specify the location of InstanceInfo

* Make json round trip test validate schema

* Add InstanceManager

* Fix lint errors

* Extra tests

* Add final test coverage

* Add one last test to InstanceManager

* Response to comments

* Use generator rather than return anonumous generator

Co-authored-by: Hornwitser <github@hornwitser.no>

* Fix lint issue with generator

---------

Co-authored-by: Hornwitser <github@hornwitser.no>
This commit is contained in:
Cooldude2606andHornwitser authored and GitHub committed 2026-03-01 23:04:37 +00:00
1 parent 5bea930d05
commit 2235294c59
60 files changed
+3371 -1227

No files matched your search

+30
View File
@@ -180,6 +180,21 @@ describe("lib/datastore", function() {
await fs.copy(path.join(testFiles, "json", "invalid.json"), dataPath);
await assert.rejects(() => datastoreProvider.load(dataPath));
});
it("writes a backup if size changes after load", async function() {
datastoreProvider = new lib.JsonDatastoreProvider(
dataPath,
json => json, // Nop
rawJson => rawJson, // Nop
() => undefined, // Throw away all data
);
const entriesBefore = await fs.readdir(baseDir);
const loadedData = await datastoreProvider.load();
const entriesAfter = await fs.readdir(baseDir);
assert.equal(entriesAfter.length, entriesBefore.length + 1, "Backup was not created");
assert.equal(loadedData.size, 0);
});
});
});
@@ -260,6 +275,21 @@ describe("lib/datastore", function() {
await fs.copy(path.join(testFiles, "json", "invalid.json"), dataPath);
await assert.rejects(() => datastoreProvider.load(dataPath));
});
it("writes a backup if size changes after load", async function() {
datastoreProvider = new lib.JsonIdDatastoreProvider(
dataPath,
json => json, // Nop
rawJson => rawJson, // Nop
() => undefined, // Throw away all data
);
const entriesBefore = await fs.readdir(baseDir);
const loadedData = await datastoreProvider.load();
const entriesAfter = await fs.readdir(baseDir);
assert.equal(entriesAfter.length, entriesBefore.length + 1, "Backup was not created");
assert.equal(loadedData.size, 0);
});
});
});