Refactor user and instance manager (#837)

* Refactor UserManager to use Datastore

* Rename lib.User to UserDetails also adds to/fromUserDetails

* Fix existing tests

* Add user class tests

* Add tests for finaliseUsers

* Move HostDetails to own file with tests

* Move InstanceDetails to its own file with tests

* Rename HostInfo and add tests

* Rename InstanceInfo and add tests

- Also changes the names of the host properties related to instances
- Also removes the need to specify the location of InstanceInfo

* Make json round trip test validate schema

* Add InstanceManager

* Fix lint errors

* Extra tests

* Add final test coverage

* Add one last test to InstanceManager

* Response to comments

* Use generator rather than return anonumous generator

Co-authored-by: Hornwitser <github@hornwitser.no>

* Fix lint issue with generator

---------

Co-authored-by: Hornwitser <github@hornwitser.no>

test/common.js

@@ -1,5 +1,6 @@
 "use strict";
 const assert = require("assert").strict;
+const { compile } = require("@clusterio/lib");
 
 /**
  * Generate a flat array of tests from a matrix of inputs.
@@ -21,11 +22,16 @@ function testMatrix(...arrays) {
  * @param {T[]} tests - The tests inputs to pass to the class constructor.
  */
 function testRoundTripJsonSerialisable(Class, tests) {
+	const validate = compile(Class.jsonSchema);
 	for (const test of tests) {
 		const original = new Class(...test);
 		const serialised = JSON.stringify(original);
-		const reconstructed = Class.fromJSON(JSON.parse(serialised));
+		const jsonObject = JSON.parse(serialised);
+		const reconstructed = Class.fromJSON(jsonObject);
 		assert.deepEqual(reconstructed, original, JSON.stringify(test));
+		if (!validate(jsonObject)) {
+			throw validate.errors;
+		}
 	}
 }