From 20e620993bdccee1a63ae0ddeb0dd922a062633c Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Tue, 11 Oct 2022 13:25:30 +0200 Subject: [PATCH] Use Factorio's version component names Minor nitpick: The coponent names of the Factorio version is called main, major, minor. Change integerFactorioVersion to match. --- packages/lib/data/version.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/lib/data/version.js b/packages/lib/data/version.js index 52588c26..32706c04 100644 --- a/packages/lib/data/version.js +++ b/packages/lib/data/version.js @@ -26,8 +26,8 @@ function integerModVersion(version) { * @alias module:lib/data.integerFactorioVersion */ function integerFactorioVersion(version) { - const [major, minor, sub] = version.split(".").map(n => Number.parseInt(n, 10)); - return major * 0x100000000 + minor * 0x10000 + (sub || 0); // Can't use bitwise here because this is 48-bits. + const [main, major, minor] = version.split(".").map(n => Number.parseInt(n, 10)); + return main * 0x100000000 + major * 0x10000 + (minor || 0); // Can't use bitwise here because this is 48-bits. } /**