mirror of
https://github.com/clusterio/clusterio.git
synced 2026-11-12 23:04:52 +09:00
Terminate deleted user sessions immediately
Drop the special case that deferred terminating the connection issuing the delete, so deleting yourself behaves the same as revoke-token and every session of the deleted user is closed before the handler returns. Set tokenValidAfter to the current time in createUser instead of 0. Deleting a user and recreating it under the same name left tokens issued before the deletion valid, as the check is iat < tokenValidAfter. Doing it in createUser covers every path that makes a user. A token signed in the same second as creation is still accepted, so create-admin and the other production paths sign after the user exists and are unaffected. The integration harness signed the control token at import time, before bootstrap create-admin created the user. Sign it in the root before hook instead and reuse it in link.js. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
fb71ee7282
commit
1da7c1da67
6 files changed
+30
-16
No files matched your search
@@ -135,12 +135,10 @@ describe("controller/src/ControlConnection", function() {
|
||||
assert.equal(admin.connector.terminated, false);
|
||||
});
|
||||
|
||||
it("terminates its own connection after the handler returns", async function() {
|
||||
it("terminates its own connection when deleting itself", async function() {
|
||||
const player = connect("player");
|
||||
|
||||
await deleteUser(player, "player");
|
||||
assert.equal(player.connector.terminated, false);
|
||||
await new Promise(resolve => setImmediate(resolve));
|
||||
assert.equal(player.connector.terminated, true);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user