From 17480aafffd5ec5d7905e5edbccae83b1bc4717a Mon Sep 17 00:00:00 2001 From: Danielv123 Date: Sat, 21 Feb 2026 17:16:06 +0100 Subject: [PATCH] fix(minimap): clarify dual filter API pattern in data source Dual filter API methods (setInstanceSurfaceFilters and setInstanceSurfaceFilter) both exist for backward compatibility with different plugin implementations. Added comment explaining why both are checked in fallback pattern. --- plugins/minimap/web/dataSources/SingleInstanceDataSource.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/minimap/web/dataSources/SingleInstanceDataSource.ts b/plugins/minimap/web/dataSources/SingleInstanceDataSource.ts index de5a4287..37428df0 100644 --- a/plugins/minimap/web/dataSources/SingleInstanceDataSource.ts +++ b/plugins/minimap/web/dataSources/SingleInstanceDataSource.ts @@ -17,6 +17,8 @@ import type { } from "../minimap-data-source"; interface MinimapWebPlugin { + // Dual filter API: plural version accepts array (flexible), singular version is a convenience wrapper. + // Both exist for backward compatibility with different plugin implementations (check plural first, then singular). setInstanceSurfaceFilters?(filters: Array<{ instanceId: number; surface: string }> | null): Promise | void; setInstanceSurfaceFilter?(instanceId: number | null, surface: string | null): Promise | void; onTileUpdate(callback: (event: TileDataEvent) => void): void;