Add download save feature

Add command and web interface button to download saves from instances.

test/integration/clusterio.js

@@ -377,6 +377,20 @@ describe("Integration of Clusterio", function() {
 			});
 		});
 
+		describe("instance download-save", function() {
+			it("should download a save", async function() {
+				await fs.remove(path.join("temp", "test", "upload.zip"));
+				await execCtl("instance download-save 44 upload.zip");
+				assert(await fs.pathExists(path.join("temp", "test", "upload.zip")));
+			});
+			it("should error if save does not exist", async function() {
+				await assert.rejects(execCtl("instance download-save 44 invalid"));
+			});
+			it("should error on path traversal attacks", async function() {
+				await assert.rejects(execCtl("instance download-save 44 ../factorio-current.log"));
+			});
+		});
+
 		describe("instance delete-save", function() {
 			it("should delete a save", async function() {
 				await execCtl("instance delete-save 44 upload.zip");

test/master/routes.js

@@ -6,6 +6,7 @@ const jwt = require("jsonwebtoken");
 const http = require("http");
 const phin = require("phin");
 
+const { wait } = require("@clusterio/lib/helpers");
 const routes = require("@clusterio/master/src/routes");
 const mock = require("../mock");
 
@@ -27,7 +28,13 @@ describe("master/src/routes", function() {
 	});
 	describe("/api/stream/:id", function() {
 		it("should respond with 404 if stream doesn't exist", async function() {
-			let response = await phin(`http://localhost:${port}/api/stream/01020304`);
+			let response;
+			response = await phin(`http://localhost:${port}/api/stream/01020304`);
+			assert.equal(response.statusCode, 404);
+			response = await phin({
+				url: `http://localhost:${port}/api/stream/01020304`, method: "PUT",
+				data: "test stream",
+			});
 			assert.equal(response.statusCode, 404);
 		});
 		it("should respond with 500 if stream times out", async function() {
@@ -35,6 +42,38 @@ describe("master/src/routes", function() {
 			let response = await phin(`http://localhost:${port}/api/stream/${stream.id}`);
 			assert.equal(response.statusCode, 500);
 		});
+		it("should passthrough a stream", async function() {
+			let stream;
+			let responses;
+			stream = await routes.createProxyStream(master.app);
+			responses = await Promise.all([
+				(async function() {
+					await wait(100);
+					return await phin({
+						url: `http://localhost:${port}/api/stream/${stream.id}`, method: "PUT",
+						data: "test content",
+					});
+				}()),
+				phin(`http://localhost:${port}/api/stream/${stream.id}`),
+			]);
+			assert.equal(responses[0].statusCode, 200);
+			assert.equal(responses[1].statusCode, 200);
+			assert.equal(responses[1].body.toString(), "test content");
+			stream = await routes.createProxyStream(master.app);
+			responses = await Promise.all([
+				phin({
+					url: `http://localhost:${port}/api/stream/${stream.id}`, method: "PUT",
+					data: "test content",
+				}),
+				(async function() {
+					await wait(100);
+					return await phin(`http://localhost:${port}/api/stream/${stream.id}`);
+				}()),
+			]);
+			assert.equal(responses[0].statusCode, 200);
+			assert.equal(responses[1].statusCode, 200);
+			assert.equal(responses[1].body.toString(), "test content");
+		});
 	});
 	describe("/api/upload-save", function() {
 		it("should respond with 401 with invalid token", async function() {