Add NO_EXTERNAL_TEST flag to skip tests using external APIs

Adds an externalTest(this) helper alongside slowTest that skips the test
when NO_EXTERNAL_TEST is set and raises the timeout to 60s, plus a
no-external-test script. Marks the tests hitting factorio.com, the mod
portal and GitHub with it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
bbassieandClaude Fable 5 committed 2026-08-18 19:55:18 +00:00
1 parent 0be4fd77e5
commit 0cfa048d42
8 files changed
+34 -6

No files matched your search

+3 -1
View File
@@ -9,6 +9,7 @@ const JSZip = require("jszip"); // Added for creating mock zips
const nativeFetch = global.fetch;
const { ModStore, ModInfo, ModVersionEquality } = require("@clusterio/lib"); // Adjust path based on compiled output
const { externalTest } = require("../integration");
const MODS_DIR = path.join("temp", "test", "mod_store", "mods");
const CACHE_FILE = path.join(MODS_DIR, "mod-info-cache.json");
@@ -582,7 +583,7 @@ describe("lib/ModStore", function () {
// It requires network access and may take a while to run.
// It might also break if the API changes or is unavailable.
it("should fetch all mods from the LIVE portal API and check structure/count", async function () {
this.timeout(60000); // Increase timeout to 60 seconds for live API call
externalTest(this);
// Ensure we are using the true native fetch we captured earlier
global.fetch = nativeFetch;
assert.strictEqual(
@@ -700,6 +701,7 @@ describe("lib/ModStore", function () {
await assert.rejects(ModStore.fetchModReleases("my-mod"));
});
it("should fetch from the correct api url (live)", async function() {
externalTest(this);
global.fetch = nativeFetch;
const result = await ModStore.fetchModReleases("clusterio_lib");
assert(result.releases && result.releases.length > 1, "Failed to fetch releases");
+2 -1
View File
@@ -2,7 +2,7 @@ const assert = require("assert").strict;
const { readFile } = require("node:fs/promises");
const { fetchFactorioVersions } = require("@clusterio/lib");
const { slowTest } = require("../../integration");
const { slowTest, externalTest } = require("../../integration");
describe("FactorioVersions", function() {
describe("fetchFactorioVersions", function() {
@@ -129,6 +129,7 @@ describe("FactorioVersions", function() {
});
it("parses versions from live api", async function() {
slowTest(this);
externalTest(this);
global.fetch = originalFetch;
const versions = await fetchFactorioVersions();
+2 -1
View File
@@ -1,7 +1,7 @@
const assert = require("assert").strict;
const { fetchLatestReleases, resolveReleaseChannel } = require("@clusterio/lib");
const { slowTest } = require("../../integration");
const { slowTest, externalTest } = require("../../integration");
describe("LatestReleases", function() {
describe("fetchLatestReleases", function() {
@@ -54,6 +54,7 @@ describe("LatestReleases", function() {
});
it("fetches from the live api", async function() {
slowTest(this);
externalTest(this);
global.fetch = originalFetch;
const releases = await fetchLatestReleases();