From e9225a4b2c94b2cd3170a2ad3fd8d22d0ba8ab93 Mon Sep 17 00:00:00 2001 From: J87 <68929154+jake-87@users.noreply.github.com> Date: Tue, 7 Dec 2021 21:38:46 +1100 Subject: [PATCH 1/4] Wrong capitalisation on `process.env` --- packages/ctl/ctl.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ctl/ctl.js b/packages/ctl/ctl.js index 293e1555..0120b144 100755 --- a/packages/ctl/ctl.js +++ b/packages/ctl/ctl.js @@ -38,7 +38,7 @@ function print(...content) { async function getEditor(argsEditor) { // eslint-disable-next-line - return argsEditor || process.ENV.EDITOR || process.env.VISUAL || -1 + return argsEditor || process.env.EDITOR || process.env.VISUAL || -1 // needed for the process.env statements to not be flagged by eslint // priority for editors is CLI argument > env.EDITOR > env.VISUAL } From 3e1a41393aa1738f4fa941d3515d3f836efef42b Mon Sep 17 00:00:00 2001 From: J87 <68929154+jake-87@users.noreply.github.com> Date: Tue, 7 Dec 2021 21:42:10 +1100 Subject: [PATCH 2/4] Fix incorrrent spelling of variable Honestly not sure how this one slipped through --- packages/ctl/ctl.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ctl/ctl.js b/packages/ctl/ctl.js index 0120b144..29ad7a70 100755 --- a/packages/ctl/ctl.js +++ b/packages/ctl/ctl.js @@ -176,7 +176,7 @@ masterConfigCommands.add(new libCommand.Command({ throw new libErrors.CommandError(`No editor avalible. Checked CLI input, EDITOR and VISUAL env vars Try "ctl master config edit "`); } - let allConfigElements = await serializedConfigToString(respose.serialized_config, libConfig.MasterConfig, {}); + let allConfigElements = await serializedConfigToString(response.serialized_config, libConfig.MasterConfig, {}); await fs.writeFile(tmpFile, allConfigElements, (err) => { if (err) { throw err; @@ -437,7 +437,7 @@ instanceConfigCommands.add(new libCommand.Command({ } let disallowedList = {"instance.id": 0, "instance.assigned_slave": 0, "factorio.settings": 0}; let allConfigElements = await serializedConfigToString( - respose.serialized_config, + response.serialized_config, libConfig.InstanceConfig, disallowedList ); From c69672ec60fd09c0b3bad9b8ceabbf4ae1d40f29 Mon Sep 17 00:00:00 2001 From: J87 <68929154+jake-87@users.noreply.github.com> Date: Tue, 7 Dec 2021 21:42:58 +1100 Subject: [PATCH 3/4] Variable misspelling --- packages/ctl/ctl.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ctl/ctl.js b/packages/ctl/ctl.js index 29ad7a70..34d97909 100755 --- a/packages/ctl/ctl.js +++ b/packages/ctl/ctl.js @@ -70,7 +70,7 @@ async function configToKeyVal(data) { async function serializedConfigToString(serlializedConfig, configGroup, disallowedList) { let allConfigElements = ""; - for (let group of serializedConfig.groups) { + for (let group of serlializedConfig.groups) { for (let [name, value] of Object.entries(group.fields)) { if (`${group.name}.${name}` in disallowedList) { continue; From fb85869d099f894e2dcf4e43ea99acdb9f8e8e03 Mon Sep 17 00:00:00 2001 From: J87 <68929154+jake-87@users.noreply.github.com> Date: Tue, 7 Dec 2021 22:13:28 +1100 Subject: [PATCH 4/4] Fix spelling mistake --- packages/ctl/ctl.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ctl/ctl.js b/packages/ctl/ctl.js index 34d97909..1c4ab74d 100755 --- a/packages/ctl/ctl.js +++ b/packages/ctl/ctl.js @@ -68,9 +68,9 @@ async function configToKeyVal(data) { return final; } -async function serializedConfigToString(serlializedConfig, configGroup, disallowedList) { +async function serializedConfigToString(serializedConfig, configGroup, disallowedList) { let allConfigElements = ""; - for (let group of serlializedConfig.groups) { + for (let group of serializedConfig.groups) { for (let [name, value] of Object.entries(group.fields)) { if (`${group.name}.${name}` in disallowedList) { continue;